Support for multi select fields#28
Merged
kylegregory merged 1 commit intokylegregory:masterfrom Aug 23, 2017
SMarioMan:master
Merged
Support for multi select fields#28kylegregory merged 1 commit intokylegregory:masterfrom SMarioMan:master
kylegregory merged 1 commit intokylegregory:masterfrom
SMarioMan:master
Conversation
…of text and other data types to work.
Owner
|
@SMarioMan, This is great. And definitely something I've wanted to do, so appreciate your work. Changing the property types, however, will potentially break code for some folks. I'm thinking this will be part of a 1.1 release. I'll see about doing so in a few days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been having issues using text[] fields with this API wrapper, which is related to issue #24 where multi-checkbox fields don't work properly. @kylegregory had the smart idea to override the base class, which I've been doing this to overcome these limitations. As overriding classes and then modifying the existing functions that use them is tedious and messy, I have decided to make the change myself and contribute it to the project.