Fixed error message duplication #491
Conversation
+ check if twitter is connected before awarding points in PointSystem.ts
Fixed misleading error messages in crosschainOperation case that incorrectly referenced "storageProgram". The error logs and console output now correctly identify crosschainOperation failures. - Updated log.error message - Updated result.extra field - Updated console.log message
|
Caution Review failedFailed to post review comments WalkthroughImplements Storage Programs feature with comprehensive access control and size validation. Adds new RPC endpoint for querying storage data. Updates GCR entity schema to support storage metadata. Consolidates documentation. Bumps SDK dependency version. Updates gitignore. Changes
Sequence DiagramsequenceDiagram
participant Client
participant RPC as server_rpc.ts
participant Handler as handleStorageProgramTransaction.ts
participant Validator as Validators
participant GCR as handleGCR.ts
participant DB as Database
Client->>RPC: Execute storage program transaction
RPC->>Handler: handleStorageProgramTransaction(payload, sender)
Handler->>Validator: Validate operation & access control
Validator-->>Handler: Validation result
alt Validation fails
Handler-->>RPC: Error response
RPC-->>Client: Failed result
else Validation succeeds
Handler->>Validator: validateStorageProgramData(size/depth/keys)
Validator-->>Handler: Data constraints valid
Handler->>Handler: Create GCREdit (CREATE/WRITE/UPDATE_ACCESS_CONTROL/DELETE)
Handler-->>RPC: { success, gcrEdits }
RPC->>GCR: Apply storage program edits
GCR->>Validator: Enforce access & size limits
GCR->>DB: Persist GCRMain with data
GCR-->>RPC: Success
RPC-->>Client: Transaction confirmed
end
Client->>RPC: Query getStorageProgram (sender, address)
RPC->>RPC: manageNodeCall(payload, sender)
RPC->>DB: Load GCRMain
RPC->>Validator: validateStorageProgramAccess(READ_STORAGE, sender)
Validator-->>RPC: Access granted/denied
alt Access denied
RPC-->>Client: 403 Forbidden
else Access granted
RPC-->>Client: Program data + metadata
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This PR modifies Files that will be reverted:
|
PR Compliance Guide 🔍(Compliance updated until commit 32a34b5)Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label Previous compliance checksCompliance check up to commit 32a34b5
|
||||||||||||||||||||||||||||||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||||||
PR Type
Enhancement, Tests
Description
Implement Storage Programs Phase 2-4: Complete CRUD operations with access control
Add transaction handlers for CREATE, WRITE, UPDATE_ACCESS_CONTROL, DELETE operations
Implement access control validator with 4 modes (private, public, restricted, deployer-only)
Add size validators (128KB limit, 64-level nesting, 256-char keys)
Integrate Storage Programs into GCR edit application and RPC endpoints
Add getStorageProgram RPC query endpoint with access control enforcement
Update SDK dependency to v2.4.24 for Storage Programs support
Diagram Walkthrough
File Walkthrough
8 files
Storage Program transaction handler with 5 operationsAdd Storage Program GCR edit application logicAccess control validator for 4 permission modesSize and structure validators for Storage ProgramsAdd getStorageProgram RPC query endpointRoute storageProgram transactions to handlerAdd data JSONB column for Storage ProgramsPass sender context to manageNodeCall1 files
Update demosdk dependency to v2.4.248 files
Complete Storage Programs implementation referenceSerena memory index with consolidation guideTelegram Identity System complete implementationStorage Programs review session findingsTelegram identities PR review resolutionDevelopment guidelines and best practicesFinal session checkpoint for Telegram identitiesCore project context and architecture overview23 files
Summary by CodeRabbit
New Features
Dependencies
Chores