Skip to content

Preserve structured JsonElement tool arguments in GitHub Copilot agent events #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kzu merged 2 commits into from
Mar 24, 2026
Merged

Preserve structured JsonElement tool arguments in GitHub Copilot agent events #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abcf955
Implement raw JsonElement argument handling
Copilot Mar 24, 2026
501587b
Fix test validation and preserve structured JSON args
Copilot Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dotnet/src/Microsoft.Agents.AI.GitHub.Copilot/GitHubCopilotAgent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,6 +500,9 @@ internal AgentResponseUpdate ConvertToolCompleteToAgentResponseUpdate(ToolExecut
JsonValueKind.Number => property.Value.TryGetInt64(out long l)
? (object?)l
: property.Value.GetDouble(),
JsonValueKind.Object => property.Value.Clone(),
JsonValueKind.Array => property.Value.Clone(),
JsonValueKind.Undefined => null,
_ => property.Value.GetRawText()
};
}
Expand Down
11 changes: 8 additions & 3 deletions dotnet/tests/Microsoft.Agents.AI.GitHub.Copilot.UnitTests/GitHubCopilotAgentTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,8 @@ public void ConvertToolStartToAgentResponseUpdate_WithAllJsonValueKinds_Converts
nullVal = (string?)null,
intVal = 100,
floatVal = 3.14,
objVal = new { nested = "value" }
objVal = new { nested = "value" },
arrVal = new List<int> { 1, 2, 3 }
})
}
};
Expand All @@ -367,8 +368,12 @@ public void ConvertToolStartToAgentResponseUpdate_WithAllJsonValueKinds_Converts
Assert.Null(content.Arguments["nullVal"]);
Assert.Equal(100L, content.Arguments["intVal"]);
Assert.Equal(3.14, (double)content.Arguments["floatVal"]!, 2);
// Non-primitive values fall back to raw JSON text
Assert.IsType<string>(content.Arguments["objVal"]);
JsonElement objValElement = Assert.IsType<JsonElement>(content.Arguments["objVal"]);
Assert.Equal(JsonValueKind.Object, objValElement.ValueKind);
Assert.Equal("value", objValElement.GetProperty("nested").GetString());
JsonElement arrValElement = Assert.IsType<JsonElement>(content.Arguments["arrVal"]);
Assert.Equal(JsonValueKind.Array, arrValElement.ValueKind);
Assert.Equal(3, arrValElement.GetArrayLength());
}

[Fact]
Expand Down
Loading