Lazy init hashes in CTransaction #21
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0rinc
changed the title
hodlinator
reviewed
Sep 9, 2025
l0rinc
force-pushed
the
l0rinc/tx-hash
branch
from
bf01d6f to
feb458e
Compare
l0rinc
commented
Sep 9, 2025
| if (a.nLockTime != b.nLockTime || a.version != b.version || a.vin.size() != b.vin.size() || a.vout.size() != b.vout.size()) { | ||
| return false; | ||
| } | ||
| return a.GetWitnessHash() == b.GetWitnessHash(); |
Owner
Author
There was a problem hiding this comment.
TODO out-of-band comment by @hodlinator:
Looking further up, computing the hashes entails serializing the transaction we've just deserialized.. Maybe could have an alternative ctor which takes in the raw memory.
Owner
Author
|
Split out the first commit to bitcoin#33353 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.