Implement custom scroll handling for ThreeJS scene container#676
Merged
Implement custom scroll handling for ThreeJS scene container#676
Conversation
Signed-off-by: rafi <refaei.shikho@hotmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds custom wheel/scroll handling around the ThreeJS canvas so mouse-wheel input over the scene scrolls the page instead of being consumed by the ThreeJS controls/canvas.
Changes:
- Wrapped the
<Canvas />in a container<div>with a ref. - Added a
wheelevent listener (capture, non-passive) to prevent default wheel behavior and forward scrolling towindow.scrollBy.
Comments suppressed due to low confidence (2)
src/components/threejs/ThreeJSScene.tsx:108
window.scrollBy(0, e.deltaY)assumesdeltaYis in pixels.WheelEvent.deltaModecan be LINE or PAGE on some devices/browsers, which will make scrolling far too slow/fast. Consider normalizing the scroll distance based one.deltaModebefore callingscrollBy.
const handleWheel = (e: WheelEvent) => {
e.stopPropagation();
e.preventDefault();
window.scrollBy(0, e.deltaY);
};
src/components/threejs/ThreeJSScene.tsx:107
- This handler calls
preventDefault()for every wheel event, which will also block browser/page zoom gestures that are implemented asctrl/trackpad-pinch + wheel (common accessibility workflow). Consider allowing default behavior whene.ctrlKey(and possiblye.metaKey) is pressed, or otherwise scoping the prevention so you don't disable zoom.
const handleWheel = (e: WheelEvent) => {
e.stopPropagation();
e.preventDefault();
window.scrollBy(0, e.deltaY);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
timbastin
reviewed
Mar 5, 2026
…ucture Signed-off-by: rafi <refaei.shikho@hotmail.com>
timbastin
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.