Skip to content

fix: assert safe dynamic sql history queries#12

Merged
l50 merged 2 commits into
mainfrom
fix/sqlx-09-sql-safety
May 22, 2026
Merged

fix: assert safe dynamic sql history queries#12
l50 merged 2 commits into
mainfrom
fix/sqlx-09-sql-safety

Conversation

@l50
Copy link
Copy Markdown
Owner

@l50 l50 commented May 22, 2026

Key Changes:

  • Wrapped dynamically assembled SQL queries with sqlx safety assertions to satisfy runtime query APIs
  • Preserved parameter binding for all user-controlled values so query construction remains injection-safe
  • Documented why dynamic hash search SQL is safe to assert despite being assembled from conditional static fragments

Changed:

  • History CLI query execution now passes constructed cost, list, credential search, and hash search SQL through sqlx::AssertSqlSafe while continuing to bind filters and limits separately - ares-cli history commands
  • Persistent credential hash searches now assert dynamically generated SQL as safe and clarify that only static fragments and placeholder indices are interpolated, with all values still supplied through bind parameters - ares-core persistent store queries

l50 added 2 commits May 21, 2026 20:46
**Changed:**

- Wrapped dynamically assembled history queries with `AssertSqlSafe` so sqlx accepts SQL built from static fragments with bound user values - `ares-cli/src/history`
- Documented and applied the same safety assertion to credential hash search queries that construct placeholder lists dynamically - `ares-core/src/persistent_store/queries/credentials.rs`
@l50 l50 merged commit 835f80e into main May 22, 2026
10 checks passed
@l50 l50 deleted the fix/sqlx-09-sql-safety branch May 22, 2026 03:38
l50 added a commit that referenced this pull request May 27, 2026
* fix: assert safety for dynamic sqlx history queries

**Changed:**

- Wrapped dynamically assembled history queries with `AssertSqlSafe` so sqlx accepts SQL built from static fragments with bound user values - `ares-cli/src/history`
- Documented and applied the same safety assertion to credential hash search queries that construct placeholder lists dynamically - `ares-core/src/persistent_store/queries/credentials.rs`

* build: update windows-sys lockfile dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant