Copy loc objects in stampLoc instead of sharing references#135
Merged
Conversation
Each node now gets its own {start, end} copy so a downstream consumer
mutating one node's loc cannot accidentally affect every other node
in the same stamped subtree.
The function accesses node.expression.end but the JSDoc declared the
parameter as plain AstNode. Tighten to AstNode & { expression: AstNode }
so the contract matches the actual usage.
Assert expression.end as number to satisfy TS18048, and cast node at the call site to match the narrowed parameter type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stampLocpreviously assigned the samelocobject reference to every node in the subtreeThis was part of #134 but got dropped by the squash merge.
Test plan