Handle spawn errors and fix O(n²) line counting#139
Merged
Conversation
- exec(): add error handlers for spawn failure and stdin EPIPE to prevent the promise from hanging indefinitely - extractBlocks(): track line count incrementally across matches instead of slicing from the start for each block
The function is already async, so use await fs.readFile() to avoid blocking the event loop for callers using the public API.
readme-assert README.md now works alongside --file/-f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
errorhandler on the spawned child anderrorhandler on stdin to prevent the promise from hanging ifnodecan't be found or the child exits before consuming all stdin (EPIPE)markdown.slice(0, blockStart).split('\n')for each block, reducing line counting from O(n²) to O(n)Test plan