This repository was archived by the owner on Jan 15, 2026. It is now read-only.
Replace utility classes with sklearn classes in NB2 #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosecers
reviewed
Nov 18, 2020
| ")\n", | ||
| "from utilities.kernels import linear_kernel, gaussian_kernel, center_kernel\n", | ||
| "from utilities.classes import PCA, LR, PCovR\n", | ||
| "from utilities.classes import PCovR # to be replaced with scalers from skcosmo\n", |
Contributor
There was a problem hiding this comment.
did you mean to say scalers here?
Contributor
Author
There was a problem hiding this comment.
Sorry. It should be "to be replaced with the class from skcosmo".
rosecers
suggested changes
Nov 18, 2020
Contributor
rosecers
left a comment
rosecers
left a comment
There was a problem hiding this comment.
just a few typos to fix
PKGuo
changed the title
rosecers
approved these changes
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace some utility classes in
2_PrincipalCovariatesRegression.ipynbwith appropriatesklearnclasses and modified the corresponding text.