Merged
Conversation
commit 8994a32 Author: Troy Prince <troy.prince@lab49.com> Date: Thu Jun 10 14:42:08 2021 -0400 Added full fetch depth commit c02922e Author: Troy Prince <troy.prince@lab49.com> Date: Thu Jun 10 14:35:31 2021 -0400 added headless chrome launcher for ci/cd commit 666aafb Author: Troy Prince <troy.prince@lab49.com> Date: Thu Jun 10 14:00:59 2021 -0400 all in one job commit e23642c Author: Troy Prince <troy.prince@lab49.com> Date: Thu Jun 10 13:28:15 2021 -0400 merged to one job commit 7049b93 Author: Troy Prince <troy.prince@lab49.com> Date: Thu Jun 10 13:26:32 2021 -0400 added chromatic action in separate file
… classes accordingly, and config for loading a global style to storybook
| @@ -0,0 +1,41 @@ | |||
| .make-it-nice { | |||
There was a problem hiding this comment.
This file should probably go into the stories directory maybe?
Contributor
Author
There was a problem hiding this comment.
Good thought, I made a styles folder under stories and added it there, and removed the src folder I made, makes more sense this way because we don't really have a project root src
brian-mcallister-lab49
approved these changes
Jun 28, 2021
Member
brian-mcallister-lab49
left a comment
brian-mcallister-lab49
left a comment
There was a problem hiding this comment.
Looks good, just that one minor comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a few changes: