Skip to content

Update non-React dependencies.#46

Merged
brian-mcallister-lab49 merged 1 commit intomainfrom
bm-update-outdated-libs
Apr 12, 2022
Merged

Update non-React dependencies.#46
brian-mcallister-lab49 merged 1 commit intomainfrom
bm-update-outdated-libs

Conversation

@brian-mcallister-lab49
Copy link
Copy Markdown
Member

No description provided.

@brian-mcallister-lab49 brian-mcallister-lab49 enabled auto-merge (squash) April 12, 2022 16:44
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 12, 2022

Codecov Report

Merging #46 (6b5e486) into main (825f8eb) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   97.22%   97.14%   -0.08%     
==========================================
  Files           1        1              
  Lines          36       35       -1     
  Branches       14       14              
==========================================
- Hits           35       34       -1     
  Misses          1        1              
Impacted Files Coverage Δ
src/OrderBook.tsx 97.14% <ø> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 825f8eb...6b5e486. Read the comment docs.

@brian-mcallister-lab49
Copy link
Copy Markdown
Member Author

I'm not worried about the drop in coverage, it's so minor and likely the result of deleting a few lines of code here and there to account for updated lint errors.

Comment thread package.json
"@storybook/preset-create-react-app": "^3.1.4",
"@storybook/preset-typescript": "^3.0.0",
"@storybook/react": "^6.2.9",
"@storybook/react": "^6.1.21",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering, why storybook is downgraded, approving anyways

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, good catch. I upgraded a bunch of Storybook libraries by running npx sb upgrade. It could be because we're using React 16 in this particular library right now.

@brian-mcallister-lab49 brian-mcallister-lab49 merged commit 7308723 into main Apr 12, 2022
@brian-mcallister-lab49 brian-mcallister-lab49 deleted the bm-update-outdated-libs branch April 12, 2022 17:06
@brian-mcallister-lab49 brian-mcallister-lab49 restored the bm-update-outdated-libs branch December 27, 2022 19:10
@brian-mcallister-lab49 brian-mcallister-lab49 deleted the bm-update-outdated-libs branch December 27, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants