fix(inventory): add status validation to transfer service#334
Merged
robotlearning123 merged 7 commits intomainfrom Mar 28, 2026
Merged
fix(inventory): add status validation to transfer service#334robotlearning123 merged 7 commits intomainfrom
robotlearning123 merged 7 commits intomainfrom
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
transfer() allowed moving disposed/depleted/deleted/expired items without error, inconsistent with consume/dispose which validate status. Added same status check to prevent invalid state transitions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
robotlearning123
force-pushed
the
fix/transfer-status-check
branch
from
82a4727 to
aa58fee
Compare
Member
Author
|
QA: APPROVED ✓ Clean, tested, single concern. Merge when CI green. |
merge-gate timed out (150/150 attempts) due to race condition — CI checks were still registering when merge-gate started polling. All actual checks passed. Empty commit to retrigger workflows. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
robotlearning123
added a commit
that referenced
this pull request
Mar 28, 2026
## Summary - `transfer()` allowed moving disposed/depleted/deleted/expired items without validation - Added status check consistent with `consume()`, `dispose()`, and `open_item()` - Prevents invalid inventory state transitions (e.g. transferring a disposed item to a new location) ## Test plan - [x] Added parametrized test covering all 4 inactive statuses (disposed, depleted, deleted, expired) - [x] All 52 inventory service tests pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Cong <72737794+robolearning123@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
robotlearning123
added a commit
that referenced
this pull request
Mar 28, 2026
## Summary - `transfer()` allowed moving disposed/depleted/deleted/expired items without validation - Added status check consistent with `consume()`, `dispose()`, and `open_item()` - Prevents invalid inventory state transitions (e.g. transferring a disposed item to a new location) ## Test plan - [x] Added parametrized test covering all 4 inactive statuses (disposed, depleted, deleted, expired) - [x] All 52 inventory service tests pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Cong <72737794+robolearning123@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
robotlearning123
added a commit
that referenced
this pull request
Mar 28, 2026
## Summary - `transfer()` allowed moving disposed/depleted/deleted/expired items without validation - Added status check consistent with `consume()`, `dispose()`, and `open_item()` - Prevents invalid inventory state transitions (e.g. transferring a disposed item to a new location) ## Test plan - [x] Added parametrized test covering all 4 inactive statuses (disposed, depleted, deleted, expired) - [x] All 52 inventory service tests pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Cong <72737794+robolearning123@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
transfer()allowed moving disposed/depleted/deleted/expired items without validationconsume(),dispose(), andopen_item()Test plan
🤖 Generated with Claude Code