fix(inventory): add depleted to open_item reject list#386
Merged
robotlearning123 merged 1 commit intomainfrom Mar 29, 2026
Merged
fix(inventory): add depleted to open_item reject list#386robotlearning123 merged 1 commit intomainfrom
robotlearning123 merged 1 commit intomainfrom
Conversation
robotlearning123
force-pushed
the
fix/inventory-guards-v2
branch
3 times, most recently
from
7a5135f to
4bd93e0
Compare
Depleted items (quantity=0) should not be openable. Add InventoryStatus.depleted to the status guard in open_item(). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
robotlearning123
force-pushed
the
fix/inventory-guards-v2
branch
from
4bd93e0 to
048b1ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InventoryStatus.depletedtoopen_item()status guardReplaces #365
Test plan
tests/test_inventory_guards.pyverifies depleted items raise ValidationError