fix(pubchem): add threading.Lock to cache and rate limiter#391
Merged
robotlearning123 merged 1 commit intomainfrom Mar 29, 2026
Merged
fix(pubchem): add threading.Lock to cache and rate limiter#391robotlearning123 merged 1 commit intomainfrom
robotlearning123 merged 1 commit intomainfrom
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| elapsed = now - _last_request_time | ||
| if elapsed < _MIN_INTERVAL: | ||
| time.sleep(_MIN_INTERVAL - elapsed) | ||
| _last_request_time = time.monotonic() |
robotlearning123
force-pushed
the
fix/pubchem-safety-v2
branch
from
a52f2f4 to
ca9cae2
Compare
The module-level _CACHE dict and _last_request_time float were unprotected. Add a threading.Lock to prevent data races in concurrent enrichment calls. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
robotlearning123
force-pushed
the
fix/pubchem-safety-v2
branch
from
ca9cae2 to
e6b0767
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
threading.Lockprotecting_CACHE,_cache_put, and_rate_limitReplaces #379
Test plan
tests/test_pubchem_safety.pyverifies lock exists and concurrent cache writes succeed