Conversation
Closed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
I recommend moving this to |
hevans66
reviewed
May 31, 2023
| ansible.builtin.shell: | ||
| cmd: | | ||
| tljh-config set https.enabled true | ||
| tljh-config set https.letsencrypt.email josh@labdao.xyz |
Contributor
There was a problem hiding this comment.
If we're being pedantic, I recommend moving the email to a variable, probably at the play level level for now. Will make it easier for someone to overwrite. If they provisioning for a different org.
Author
There was a problem hiding this comment.
Good points, just implemented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should I move this into it's own separate playbook so it does't run on every deploy?