Update Gradle to version 4.5, update dependency versions and fix Travis build #131

floscher · 2018-01-25T23:26:58Z

@nguillaumin as you said in #129, only updating gradle-wrapper.properties is not enough. Normally at least gradle-wrapper.jar also changes. In this case also gradlew and gradlew.bat changed. The update can be done by executing ./gradlew wrapper --gradle-version 4.5 --distribution-type all two times. Or I normally use a small shell script doing that for me: https://gist.github.com/floscher/162c8559258550a4173a6c87b2454f47

So the commits do the following:

f60f394 Update Gradle to the latest version 4.5
434bd98 Update several dependencies to their latest versions and use some newer Gradle notation
066fe28 Fix the currently failing Travis build: It's related to the issue mentioned in fixes gradle error while building apk #129 (Error: Invalid --abi armeabi-v7a for the selected target travis-ci/travis-ci#7425). Though I'm not sure if Travis is at fault or Google/Android, https://stackoverflow.com/a/45177269 seems to indicate that for some Android versions there are simply no ABI images available. See https://travis-ci.org/floscher/osmtracker-android/builds/333501292#L2110-L2132: 16 and 25 don't have an ABI image, but 19 has. That's why I changed the emulator version to 19.

EmmanuelAB · 2018-01-26T16:59:24Z

This is a better solution for the problem. I'll close the PR #129

nguillaumin · 2018-01-27T00:15:08Z

app/build.gradle

-
+    android {
+        lintOptions {
+            abortOnError false


What does this do? I usually prefer to leave warnings / errors on unless there's a good reason not to.

It's because the Android linter is finding 110 issues. By default, the build is failing as long as there are linter issues.
When this option is set to false, the linting task still displays that issues were found and writes a html and xml report, but the build doesn't fail.
If you would like to rather let the build fail until the issues are resolved, I could remove that option from the pull request.

nguillaumin · 2018-01-27T00:16:56Z

Hm, I'm always wary of updating the dependencies as it can have side effect that may be hard to detect. Did you have the chance to do a thorough testing of all the features with the new dependencies (especially upload to OSM, which is mostly what the dependencies are needed for)?

* don't let the build fail on linter issues * update gradle build tools, slf4j for Android and OSMDroid

See https://docs.travis-ci.com/user/languages/android/#Installing-a-newer-SDK-Platform-Tools-revision

floscher · 2018-01-27T15:01:40Z

I wouldn't call what I did thorough testing 😉.
The current version of the pull request now only updates slf4j-android (previous version was "only" a release candidate) and osmdroid, which actually had quite some improvements since the version previously used. See https://github.com/osmdroid/osmdroid/releases , e.g. #125 could be fixed easier with the new OSMDroid version (see osmdroid/osmdroid#573)

jamescr · 2018-01-28T00:58:23Z

I'm getting this error when trying to upload a trace to osm:

01-27 16:28:49.566 6971-7146/me.guillaumin.android.osmtracker E/AndroidRuntime: FATAL EXCEPTION: AsyncTask #1
 Process: me.guillaumin.android.osmtracker, PID: 6971
 java.lang.RuntimeException: An error occurred while executing doInBackground()
 at android.os.AsyncTask$3.done(AsyncTask.java:353)
 at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:383)
 at java.util.concurrent.FutureTask.setException(FutureTask.java:252)
 at java.util.concurrent.FutureTask.run(FutureTask.java:271)
 at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:245)
 at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
 at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
 at java.lang.Thread.run(Thread.java:764)
   Caused by: java.lang.NoSuchFieldError: No static field INSTANCE of type Lorg/apache/http/message/BasicHeaderValueFormatter; in class Lorg/apache/http/message/BasicHeaderValueFormatter; or its superclasses (declaration of 'org.apache.http.message.BasicHeaderValueFormatter' appears in /system/framework/org.apache.http.legacy.boot.jar)
 at org.apache.http.entity.ContentType.toString(ContentType.java:199)
 at org.apache.http.entity.mime.MultipartFormEntity.<init>(MultipartFormEntity.java:56)
 at org.apache.http.entity.mime.MultipartEntityBuilder.buildEntity(MultipartEntityBuilder.java:236)
 at org.apache.http.entity.mime.MultipartEntity.getEntity(MultipartEntity.java:119)
 at org.apache.http.entity.mime.MultipartEntity.isChunked(MultipartEntity.java:140)
 at org.apache.http.protocol.RequestContent.process(RequestContent.java:84)
 at org.apache.http.protocol.BasicHttpProcessor.process(BasicHttpProcessor.java:295)
 at org.apache.http.protocol.HttpRequestExecutor.preProcess(HttpRequestExecutor.java:165)
 at org.apache.http.impl.client.DefaultRequestDirector.execute(DefaultRequestDirector.java:414)
 at org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:560)
 at org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:492)
 at org.apache.http.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:470)
 at me.guillaumin.android.osmtracker.osm.UploadToOpenStreetMapTask.doInBackground(UploadToOpenStreetMapTask.java:250)
 at me.guillaumin.android.osmtracker.osm.UploadToOpenStreetMapTask.doInBackground(UploadToOpenStreetMapTask.java:41)
 at android.os.AsyncTask$2.call(AsyncTask.java:333)
 at java.util.concurrent.FutureTask.run(FutureTask.java:266)
 at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:245) 
 at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162) 
 at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636) 
 at java.lang.Thread.run(Thread.java:764)

floscher · 2018-01-28T01:01:06Z

@jamescr Which version? The current state of this PR does not update Apache HTTP. I excluded it from the version update after the comment by @nguillaumin above.

jamescr · 2018-01-28T01:50:28Z

I'm sorry @floscher I was testing the previous PR version. I had just tested and uploading traces to osm works fine.

floscher · 2018-01-28T11:06:07Z

No problem, at least we know now, that an update would have really caused issues.

EmmanuelAB · 2018-01-31T20:06:56Z

We've been testing this changes:

Generate the APK.
Create traces and upload them to OSM. Here's the proof
Export traces to gpx.

Everything is working OK, we hope this PR could be accepted.
By the way we are working in the issue #119 and we've interest in creating
a PR with our contribution (it's intended to be merged after this PR).
Also we have used our work together with the changes proposed by @floscher and
they work fine.

nguillaumin · 2018-02-02T06:15:27Z

Hi,

You guys seem really motivated to take OSMTracker one step further, which is awesome. As you may have noticed I'm not very active on the project, for lack of time and motivation. To be honest it's unlikely I'll be able to merge these PR because I don't have the time to test, and I don't want to release untested versions on the Play Market (I've been bitten by that and had to rollback after several user complaints, it was not fun).

How would you guys feel about taking the project over?

jamescr · 2018-02-09T13:34:13Z

@nguillaumin Wow!, for us would be a pleasure, thanks. But what exactly do you mean by taking over the project?

nguillaumin · 2018-02-09T15:52:01Z

I was thinking I would take down the app from the Android market, transfer the GitHub repository to you, and the you can do whatever you want 😉 (presumably re-publish it on the market under your own account and continue the development)

jamescr · 2018-02-12T18:39:44Z

Ok. I have deleted osmtracker-android repository from my github account, now I can receive the repo transfer.

Regarding the android market. We were thinking that if you take down the app from the market, we will lost the contact with the users, so when we update the app they won't be noticed. Would you mind transferring the app in the android market as well? If you agree please sent me an email jaime.cr (at) gmail.com, and I can give you any needed data.

floscher · 2018-05-22T09:53:05Z

Any updates regarding the repository transfer, is this project currently actively maintained?

And any news about this PR?

aton1698 · 2018-05-25T22:38:23Z

Hi @floscher. Yes, this project is actively maintained.
We apologize we didn't give you an answer previously, but we have being working on the repository transfer and developing a new functionatility. In a few days, we'll be checking this PR.
We do have the intention of accepting it.
We'll be in touch, thanks for contribuiting.

nguillaumin reviewed Jan 27, 2018

View reviewed changes

floscher added 3 commits January 27, 2018 15:55

Update Gradle Wrapper to version 4.5

fff913d

Update Gradle notation for dependencies and plugins

3c616b0

* don't let the build fail on linter issues * update gradle build tools, slf4j for Android and OSMDroid

Fix Travis build

23cb335

See https://docs.travis-ci.com/user/languages/android/#Installing-a-newer-SDK-Platform-Tools-revision

floscher force-pushed the gradle_update branch from 066fe28 to 23cb335 Compare January 27, 2018 14:59

jamescr assigned xsaco07 and EmmanuelAB Jun 1, 2018

jamescr merged commit fb1fcff into labexp:master Jun 16, 2018

Update Gradle to version 4.5, update dependency versions and fix Travis build #131

Update Gradle to version 4.5, update dependency versions and fix Travis build #131

Uh oh!

Conversation

floscher commented Jan 25, 2018

Uh oh!

EmmanuelAB commented Jan 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nguillaumin Jan 27, 2018

Choose a reason for hiding this comment

Uh oh!

floscher Jan 27, 2018

Choose a reason for hiding this comment

Uh oh!

nguillaumin commented Jan 27, 2018

Uh oh!

floscher commented Jan 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jamescr commented Jan 28, 2018

Uh oh!

floscher commented Jan 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jamescr commented Jan 28, 2018

Uh oh!

floscher commented Jan 28, 2018

Uh oh!

EmmanuelAB commented Jan 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nguillaumin commented Feb 2, 2018

Uh oh!

jamescr commented Feb 9, 2018

Uh oh!

nguillaumin commented Feb 9, 2018

Uh oh!

jamescr commented Feb 12, 2018

Uh oh!

floscher commented May 22, 2018

Uh oh!

aton1698 commented May 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

EmmanuelAB commented Jan 26, 2018 •

edited

Loading

floscher commented Jan 27, 2018 •

edited

Loading

floscher commented Jan 28, 2018 •

edited

Loading

EmmanuelAB commented Jan 31, 2018 •

edited

Loading

aton1698 commented May 25, 2018 •

edited

Loading