Skip to content

Conversation

@icrf2000
Copy link
Contributor

addresses #164

On high DPI devices, the map is scaled up, so texts are now readable. In addition, the track width is increased (set to 0.5mm), so the track is better visible on the map.

The upscaling introduces a minimal blurring, but it is really hardly noticable and there is no better way to do it. The map tiles are simply not available for HDPI devices, so upscaling on the device is the only option. Without it, one doesn't get happy, street names etc. are completely unreadable. Osmdroid does a fairly good job upscaling.

Note: I previously created this PR based on a wrong branch history. Sorry for this... (I just have too many branches on my devel machine, this sometimes confuses me).

aton1698 and others added 3 commits February 18, 2019 14:47
* Fix the disappearing-when-scrolling  icons in the track manager activity

* New preference: Minimum distance between subsequent track points

* Open keyboard automatically when creating a note

* Fixes issue labexp#62

* update gradle and build tools versions

* The bug that deletes the saved tags before save the trace is solved

* New translations from Transifex

* Do not allow empty string in min_logging_distance

* Solving the issue labexp#115 (labexp#179)

* Adding new icon in the bottom space in the main screen

* Changing app version to 0.7.1
@jamescr jamescr added this to the v0.7.2 milestone May 24, 2019
@EmmanuelAB
Copy link
Contributor

Thanks for contributing to the project. Because of the branch this PR is based on (master) it seems difficult to be added via merge, since master is far behind develop, a lot of conflicts appear. However the changes will be incorporated to the project.
I have created a new branch starting from current develop and cherry-picked the two commits this PR adds so it can be merged without conflicts (and it looks fine). I can make a new PR with the changes or give you the commands to make it yourself and modify this PR. Which option do you prefer @icrf2000 ?

@icrf2000
Copy link
Contributor Author

icrf2000 commented Jun 1, 2019

Hello,

I don't mind if you use your cherry-picked branch to create a new PR. I see it is indeed a bit difficult in the meantime to merge in my old one (thought it introduced only few code changes at the time when I created it).

@EmmanuelAB EmmanuelAB mentioned this pull request Jun 7, 2019
@EmmanuelAB
Copy link
Contributor

Ok. I created this new PR adding the changes. Finally this PR will be closed. Again, thanks for contributing to the project.

@EmmanuelAB EmmanuelAB closed this Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants