Improvement of strings and message in upload to GitHub functionality #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In `GitHubPullRequest.java`, it parses the JSON response from the GitHub API in case of an error during Pull Request creation. It extracts and displays specific error messages from the "errors" array in the JSON response. - In `GitHubConstants.java`, it fixes a missing slash in the `getRepoFileContentUrl` method, ensuring the correct URL is formed.
5 tasks
Kevin-Salazar-itcr
approved these changes
Aug 28, 2025
Collaborator
Kevin-Salazar-itcr
left a comment
Kevin-Salazar-itcr
left a comment
There was a problem hiding this comment.
All checked, approved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves how OSMTracker is managing the github links, user messages adding R strings, retrieving repositories message and specific error messages for PRs.
Related issues
This PR is not related to a specific issue. But is needed to keep a structured code for the next release.
Pull Request Checklist