HTTPVideo: Allow to specify port in URL#1860
Merged
Emantor merged 2 commits intolabgrid-project:masterfrom Apr 30, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1860 +/- ##
========================================
- Coverage 45.8% 45.8% -0.1%
========================================
Files 182 182
Lines 14718 14720 +2
========================================
Hits 6743 6743
- Misses 7975 7977 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gbetous-missingno
force-pushed
the
fixhttp
branch
from
04ef285 to
3417613
Compare
- Use declared port in URL if present - Declare `controls` parameter to be compatible with other streams (used by remote/client.py in drv.stream() call) Signed-off-by: Guillaume Betous <guillaume@missingno.tech>
Test URL using: - http:// - https:// - http:// with port in URL Signed-off-by: Guillaume Betous <guillaume@missingno.tech>
gbetous-missingno
force-pushed
the
fixhttp
branch
from
3417613 to
6456948
Compare
Emantor
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes and improves HTTPVideoStream usage:
Fix:
controlsparameter to be compatible with other streams (used by remote/client.py in drv.stream() call)Improvement:
http://lab.local:8080/stream.mjpg)