-
Notifications
You must be signed in to change notification settings - Fork 232
driver/quartushpsdriver: add support for Quartus HPS #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Should I include the configuration snippet from the commit message in the docs or is it self-explanatory enough? If yes, where should I include it? |
Codecov Report
@@ Coverage Diff @@
## master #206 +/- ##
========================================
- Coverage 52.7% 52.6% -0.1%
========================================
Files 91 92 +1
Lines 5161 5213 +52
========================================
+ Hits 2722 2745 +23
- Misses 2439 2468 +29
Continue to review full report at Codecov.
|
Emantor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, except your are not implementing a protocol.
I am not sure we want to include the strategy or start a seperate repository with examples. This way we could have the basic examples in here and more elaborate Strategies in another repo, splitting out that complexity from the actual library.
|
|
||
| @target_factory.reg_driver | ||
| @attr.s(cmp=False) | ||
| class QuartusHPSDriver(Driver): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to implement a Protocol. BootstrapProtocol would be the obvious choice, however your driver implements an additional feature: choosing the address of where to load the file. I am not sure that we want to extend the existing protocol or define a new one for this.
|
Pushed changes:
I have no strong opinion if more elaborate strategies should be in another repository. @jluebbe ? |
|
We discussed this internally and decided that having the FlashProtocol with this simple implementation doesn't help us much currently. Also, it would cause more churn when we add a more general FlashProtocol later. So we prefer to use the QuartusHPSDriver directly for now. |
Adds the driver itself, an example strategy and documentation.
The example strategy can be used like this:
targets
my-target:
resources:
RemotePlace:
name: 'my-target'
drivers:
- QuartusHPSDriver: {}
- SerialDriver:
txdelay: 0.01
- NetworkPowerDriver:
delay: 5.0
- BareboxDriver:
prompt: 'barebox@[^:]+:[^ ]+ '
- ShellDriver:
prompt: 'root@[^:]+:[^ ]+'
login_prompt: ' login: '
username: 'root'
- QuartusHPSStrategy:
image_xload: /path/to/barebox-xload.img
image: /path/to/barebox.img
imports:
- examples/strategy/quartusstrategy.py
Signed-off-by: Bastian Stender <bst@pengutronix.de>
|
Pushed changes:
Should the |
jluebbe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having the strategy in examples/ makes it easier to find, so I'll merge this as is.
Adds the driver itself, an example strategy and documentation.
The example strategy can be used like this:
Signed-off-by: Bastian Stender bst@pengutronix.de