Skip to content

Conversation

@kjeldflarup
Copy link
Contributor

Uses the environment variable LG_CROSSBAR and LG_CROSSBAR_REALM as defaults for crossbar URL, if they are set.

@codecov-io
Copy link

codecov-io commented Mar 1, 2018

Codecov Report

Merging #209 into master will increase coverage by <.1%.
The diff coverage is 83.3%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #209     +/-   ##
========================================
+ Coverage    52.6%   52.6%   +<.1%     
========================================
  Files          92      92             
  Lines        5213    5215      +2     
========================================
+ Hits         2745    2747      +2     
  Misses       2468    2468
Impacted Files Coverage Δ
labgrid/remote/client.py 49.1% <100%> (ø) ⬆️
labgrid/resource/remote.py 84.4% <100%> (+0.1%) ⬆️
labgrid/remote/exporter.py 35.2% <50%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c94f86...7b3669e. Read the comment docs.

@jluebbe
Copy link
Member

jluebbe commented Mar 2, 2018

I've updated your PR with some documentation and reworded the commit message a bit.
Also, the Signed-off-by line is missing, see: https://labgrid.readthedocs.io/en/latest/development.html#developer-s-certificate-of-origin

@jluebbe jluebbe self-requested a review March 2, 2018 13:05
@jluebbe jluebbe self-assigned this Mar 2, 2018
@kjeldflarup
Copy link
Contributor Author

I'm not really sure how to fix the missing sign-off, the time --amend trick seems to be passed as I merged upstream before pushing to githup.

@jluebbe
Copy link
Member

jluebbe commented Mar 2, 2018

If you are OK with it, I can also add "Signed-off-by: Kjeld Flarup kfa@deif.com" myself by rebasing it. Otherwise you can add it yourself by updating, editing the message using "git rebase -i" and force-pushing.

kjeldflarup and others added 3 commits March 2, 2018 15:45
…ts for crossbar if they exist

Signed-off-by: Kjeld Flarup <kfa@deif.com>
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
@kjeldflarup
Copy link
Contributor Author

It seems that I succeded!

@jluebbe jluebbe merged commit 59ccd91 into labgrid-project:master Mar 2, 2018
@kjeldflarup kjeldflarup deleted the search_environment_for_crossbar branch April 9, 2018 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants