Use --hostname to override exporter host name #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
There is already the --name parameter to set the name used to register resources. I've added a commit on top which implements an --hostname parameter instead of an environment variable. So far I've only tested it without real hardware. |
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
========================================
- Coverage 54.7% 54.6% -0.1%
========================================
Files 93 93
Lines 5257 5269 +12
========================================
+ Hits 2879 2881 +2
- Misses 2378 2388 +10
Continue to review full report at Codecov.
|
Contributor
Author
|
Could I get a copy of Your commit? |
Member
|
@kjeldflarup It's in this PR branch. See 144e3b8 |
Contributor
Author
|
I have testet this on my Raspberry Pi and found it working. |
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
For resources like USBSerialPort, USBGenericExport or USBSigrokExport, the exporter needs to provide a host name to set the exported value of the "host" key. If the system hostname is not resolvable via DNS, this option can be used to override this default with another name (or an IP address). Signed-off-by: Kjeld Flarup <kfa@deif.com> Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
jluebbe
approved these changes
Mar 19, 2018
jluebbe
changed the title
jluebbe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exporting USBSerialPort the exporter exports the host as the hostname. This may however not always resolve.
setting LG_HOSTNAME to ex an IP address will override gethostname() in the exporter
This variable can be used with ex. USBSerialPort, USBGenericExport, USBSigrokExport
Tested with USBSerialPort only.