Skip to content

remote/client: various fixes #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jluebbe merged 2 commits into from
Mar 15, 2017
Merged

remote/client: various fixes #25

jluebbe merged 2 commits into from
Mar 15, 2017

Conversation

@Emantor
Copy link
Member

@Emantor Emantor commented Mar 14, 2017 •
edited
Loading

This PR has two client fixes:

  • add verbosity to the client export function for tests
  • fix inaccessable places if they are fully found within another placename

@Emantor
remote/client: replace assert with explicit checks for user and host
9a0860a 
The assert only checked whether a place was acquired, explicitly check if user
and hostname match and raise an appropriate exception if they don't.

Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
@Emantor Emantor requested a review from jluebbe March 14, 2017 10:23
@coveralls
Copy link

coveralls commented Mar 14, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 47.955% when pulling 9a0860a on Emantor:fix/target_config_explicit_check into 13e9254 on labgrid-project:master.

@Emantor Emantor force-pushed the fix/target_config_explicit_check branch 2 times, most recently from 70a2f55 to 9a2c6fb Compare March 14, 2017 11:29
@coveralls
Copy link

coveralls commented Mar 14, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 47.925% when pulling 9a2c6fb on Emantor:fix/target_config_explicit_check into 13e9254 on labgrid-project:master.

@Emantor Emantor changed the title remote/client: replace assert with explicit checks for user and host remote/client: various fixes Mar 14, 2017
@coveralls
Copy link

coveralls commented Mar 14, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 48.084% when pulling 9a2c6fb on Emantor:fix/target_config_explicit_check into 13e9254 on labgrid-project:master.

@coveralls
Copy link

coveralls commented Mar 14, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 47.925% when pulling 9a2c6fb on Emantor:fix/target_config_explicit_check into 13e9254 on labgrid-project:master.

@Emantor
remote/client: if we have an exact match for a place, return it
9caee37 
Previously the client would deny access to places which are fully reachable in
other places, e.g. "abc" and "abcdef" making only "abcdef" accessable. If we
have an exact match in our match list return it immediately.

Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
@Emantor Emantor force-pushed the fix/target_config_explicit_check branch from 9a2c6fb to 9caee37 Compare March 14, 2017 12:00
@coveralls
Copy link

coveralls commented Mar 14, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 47.925% when pulling 9caee37 on Emantor:fix/target_config_explicit_check into 13e9254 on labgrid-project:master.

jluebbe
jluebbe approved these changes Mar 15, 2017
View reviewed changes
Copy link
Member

@jluebbe jluebbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jluebbe jluebbe merged commit e079981 into labgrid-project:master Mar 15, 2017
@Emantor Emantor deleted the fix/target_config_explicit_check branch March 21, 2017 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jluebbe jluebbe jluebbe approved these changes

Assignees

@jluebbe jluebbe

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Emantor @coveralls @jluebbe