graphstrategy: fix error message about multiple root states #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
root_states already contains all states without dependencies as strings. Joining only the first element of each string results in the first character of each state being printed. Fix this by joining root_states directly without a list comprehension. Signed-off-by: Bastian Krause <bst@pengutronix.de>
Codecov Report
@@ Coverage Diff @@
## master #520 +/- ##
========================================
+ Coverage 56% 56.9% +0.9%
========================================
Files 127 127
Lines 8497 8719 +222
========================================
+ Hits 4760 4967 +207
- Misses 3737 3752 +15
Continue to review full report at Codecov.
|
Emantor
approved these changes
Oct 30, 2019
jluebbe
approved these changes
Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
root_statesalready contains all states without dependencies as strings. Joining only the first element of each string results in the first character of each state being printed. Fix this by joiningroot_statesdirectly without a list comprehension.Checklist