Skip to content

Conversation

@esben
Copy link
Contributor

@esben esben commented Feb 2, 2021

Description

Add support for using Siglent SPD3000X series power supplies, such as SPD3303X and SPD3303X-E with NetworkPowerDriver.

Checklist

  • Documentation for the feature
  • Tests for the feature
  • CHANGES.rst has been updated
  • PR has been tested

@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #717 (9350e58) into master (86c112c) will decrease coverage by 0.0%.
The diff coverage is 20.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #717     +/-   ##
========================================
- Coverage    58.7%   58.7%   -0.1%     
========================================
  Files         130     131      +1     
  Lines        9330    9345     +15     
========================================
+ Hits         5484    5486      +2     
- Misses       3846    3859     +13     
Impacted Files Coverage Δ
labgrid/driver/power/siglent.py 20.0% <20.0%> (ø)
labgrid/util/agentwrapper.py 96.5% <0.0%> (-1.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86c112c...9350e58. Read the comment docs.

Copy link
Member

@jluebbe jluebbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, your Signed-off-by is missing.

Signed-off-by: Esben Haabendal <esben@geanix.com>
@jluebbe
Copy link
Member

jluebbe commented Feb 3, 2021

The CI issue is unrelated and was fixed with #721.

@Emantor Emantor merged commit da0a81d into labgrid-project:master Feb 3, 2021
@esben esben deleted the siglent-driver branch February 11, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants