driver/power/siglent: use backend function signatures expected by NetworkPowerDriver #960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…workPowerDriver
When using the siglent power backend with the NetworkPowerDriver, this
error occurs:
self = NetworkPowerDriver(target=Target(name='Test', env=None), name='power', state=<BindingState.active: 2>, delay=2.0)
@Driver.check_active
@step()
def off(self):
> self.backend.power_set(self._host, self._port, self.port.index, False)
E TypeError: power_set() takes 3 positional arguments but 4 were given
labgrid/driver/powerdriver.py:219: TypeError
The siglent backend does not follow the function signatures expected by
the NetworkPowerDriver, because it's missing the port parameter. Fix that
by adding the port parameter and making sure that it's None, just like
other backends do (apc, rest, sentry, simplerest, tplink).
Fixes: da0a81d ("driver/power: add support for Siglent SPD3000X series power supplies")
Signed-off-by: Bastian Krause <bst@pengutronix.de>
Codecov Report
@@ Coverage Diff @@
## master #960 +/- ##
========================================
- Coverage 57.1% 57.1% -0.1%
========================================
Files 150 150
Lines 11199 11201 +2
========================================
Hits 6402 6402
- Misses 4797 4799 +2
Continue to review full report at Codecov.
|
jluebbe
approved these changes
Aug 5, 2022
Bastian-Krause
removed
the
pick to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the siglent power backend with the NetworkPowerDriver, this error occurs:
The siglent backend does not follow the function signatures expected by the NetworkPowerDriver, because it's missing the port parameter. Fix that by adding the port parameter and making sure that it's
None, just like other backends do (apc, rest, sentry, simplerest, tplink).Note: I have no Siglent device here to actually test this. I stumbled upon this while trying to add a test for another power-related change.
/cc @esben
Checklist
Fixes #717