remote/client: fix automatic driver selection#795
Merged
jluebbe merged 1 commit intolabgrid-project:masterfrom Jul 9, 2021
Merged
remote/client: fix automatic driver selection#795jluebbe merged 1 commit intolabgrid-project:masterfrom
jluebbe merged 1 commit intolabgrid-project:masterfrom
Conversation
We must abort the for loop as soon as we find any matching driver. Otherwise we'd possibly overwrite it in a later iteration. This also avoids some redundant lines. Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Codecov Report
@@ Coverage Diff @@
## master #795 +/- ##
======================================
Coverage 56.7% 56.8%
======================================
Files 143 143
Lines 10617 10611 -6
======================================
+ Hits 6030 6033 +3
+ Misses 4587 4578 -9
Continue to review full report at Codecov.
|
Emantor
approved these changes
Jul 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We must abort the for loop as soon as we find any matching driver. Otherwise
we'd possibly overwrite it in a later iteration. This also avoids some
redundant lines.