ID_SERIAL_SHORT documentation fix. #841
Conversation
Example for ID_SERIAL_SHORT for USBSerialPort shouldn't have single quotes.
documentation fix for ID_SERIAL_SHORT. It shouldn't have single quotes.
| USBSerialPort: | ||
| match: | ||
| '@ID_SERIAL_SHORT': 'P-00-00682' | ||
| ID_SERIAL_SHORT: 'P-00-00682' |
There was a problem hiding this comment.
This was actually correct. '@ID_SERIAL_SHORT' means that his match must apply to a parent device.
| USBSerialPort: | ||
| match: | ||
| 'ID_SERIAL_SHORT': 'P-00-00682' | ||
| ID_SERIAL_SHORT: 'P-00-00682' |
There was a problem hiding this comment.
This should be quoted and needs a @ as well (see below).
There was a problem hiding this comment.
On the examples I was working on the code would crash if it had the ''
I didn't try with the @ tho.
However, there are code examples (commited by you :P) that do not use the quotes...
https://github.com/labgrid-project/labgrid/blob/a6571a44501df93c649fafe315d75097d95d4941/examples/barebox/local-usb.yaml
My wider issue is that the pattern seems to be different on every file I checked, which made it hard for me to tell what the expected code was.
There was a problem hiding this comment.
The output from the labgrid-suggest tool should be correct for your local system.
|
This is solved by #852. |
2 participants
Small fix for the ID_SERIAL_SHORT documentation.