try to use ID_PATH and ID_SERIAL_SHORT on the device itself #852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This PR was inspired by #841. |
Emantor
previously approved these changes
Oct 9, 2021
Bastian-Krause
requested changes
Oct 9, 2021
… matches Point to the builtin usb_id udev helper which generates these properties. Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
As the default udev configuration enables the path_id and usb_id helpers for many USB-based devices, first check if ID_PATH or ID_SERIAL_SHORT are available on the device itself. Use the parent USB device only if it's not found. Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
For ID_SERIAL_SHORT and ID_PATH with @ (parent match), no quote is needed to mark it as a string. This now matches the output from labgrid-suggest. Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Codecov Report
@@ Coverage Diff @@
## master #852 +/- ##
======================================
Coverage 56.9% 56.9%
======================================
Files 145 145
Lines 10854 10854
======================================
Hits 6179 6179
Misses 4675 4675
Continue to review full report at Codecov.
|
Emantor
approved these changes
Oct 11, 2021
Bastian-Krause
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the default udev configuration enables the path_id and usb_id helpers for
many USB-based devices, first check if ID_PATH or ID_SERIAL_SHORT are available
on the device itself. Use the parent USB device only if it's not found.
Checklist