remote/client: exit with 1 on KeyboardInterrupt #855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When concatenating commands with '&&' or using 'set -e', a keyboard interrupt should lead to no further commands being executed. To allow this, rather exit with 1 than 0 on keyboard interrupt. Fixes: ef40183 ("remote/client: catch common errors and show a help message") Signed-off-by: Bastian Krause <bst@pengutronix.de>
Bastian-Krause
added
fix
pick to stable
Codecov Report
@@ Coverage Diff @@
## master #855 +/- ##
======================================
Coverage 56.9% 56.9%
======================================
Files 145 145
Lines 10854 10854
======================================
Hits 6179 6179
Misses 4675 4675
Continue to review full report at Codecov.
|
Emantor
approved these changes
Oct 20, 2021
Bastian-Krause
removed
the
pick to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When concatenating commands with
&&or usingset -e, a keyboard interrupt should lead to no further commands being executed.To allow this, rather exit with
1than0on keyboard interrupt.Checklist
Fixes #155