use deferred imports for requests and pyudev#880
Merged
Emantor merged 2 commits intolabgrid-project:masterfrom Jan 5, 2022
Merged
use deferred imports for requests and pyudev#880Emantor merged 2 commits intolabgrid-project:masterfrom
Emantor merged 2 commits intolabgrid-project:masterfrom
Conversation
This matches the approach we have in other drivers already and improves the startup time of labgrid-client by ~11%. Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
This matches the approach we have in other placesalready and improves the startup time of labgrid-client by ~5%. Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Codecov Report
@@ Coverage Diff @@
## master #880 +/- ##
======================================
Coverage 57.0% 57.0%
======================================
Files 148 148
Lines 10970 10973 +3
======================================
+ Hits 6257 6260 +3
Misses 4713 4713
Continue to review full report at Codecov.
|
Emantor
approved these changes
Jan 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Although the parts of labgrid which need
requestsandpyudevare not used bylabgrid-client, they are still loaded every time and cause a significant startup overhead. This is especially noticeable on smaller ARM systems.Checklist