Skip to content

driver: power: rest/simplerest: raise error on power_set() if one occurred#893

Merged
jluebbe merged 2 commits intolabgrid-project:masterfrom
Bastian-Krause:bst/power-httperr-on-set
Mar 2, 2022
Merged

driver: power: rest/simplerest: raise error on power_set() if one occurred#893
jluebbe merged 2 commits intolabgrid-project:masterfrom
Bastian-Krause:bst/power-httperr-on-set

Conversation

@Bastian-Krause
Copy link
Copy Markdown
Member

Description
Do not ignore HTTP errors on power set in rest/simplerest backends.

Checklist

  • CHANGES.rst has been updated
  • [.] PR has been tested (tested rest backend, simplerest should work similarly)

Fixes #219
Fixes #723

Fixes: 2a8ac47 ("driver/power: add support for REST based relays controlling power")
Signed-off-by: Bastian Krause <bst@pengutronix.de>
Fixes: b5740cf ("driver/power: add networkpowerurl model for NetworkPowerPort")
Signed-off-by: Bastian Krause <bst@pengutronix.de>
@Bastian-Krause Bastian-Krause added fix pick to stable Needs a pick to the latest stable branch labels Feb 18, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 18, 2022

Codecov Report

Merging #893 (1567c7d) into master (72494bc) will decrease coverage by 0.0%.
The diff coverage is 0.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #893     +/-   ##
========================================
- Coverage    56.9%   56.9%   -0.1%     
========================================
  Files         149     149             
  Lines       11011   11013      +2     
========================================
  Hits         6268    6268             
- Misses       4743    4745      +2     
Impacted Files Coverage Δ
labgrid/driver/power/rest.py 27.2% <0.0%> (-2.8%) ⬇️
labgrid/driver/power/simplerest.py 0.0% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72494bc...1567c7d. Read the comment docs.

@jluebbe jluebbe merged commit 87b6652 into labgrid-project:master Mar 2, 2022
@Bastian-Krause Bastian-Krause removed the pick to stable Needs a pick to the latest stable branch label Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants