driver/qemudriver: let _read() handle max_size kwarg #940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f5226ed ("implement 'max_size' in serialdriver read") introduced a new kwarg in ConsoleExpectMixin which is passed through to the driver's internal _read() method. The QEMUDriver was not adjusted accordingly, so do that now. Fixes: f5226ed ("implement 'max_size' in serialdriver read") Signed-off-by: Bastian Krause <bst@pengutronix.de>
Signed-off-by: Bastian Krause <bst@pengutronix.de>
Bastian-Krause
force-pushed
the
bst/qemu-read-max-size
branch
from
d00c2f2 to
cde4e2a
Compare
Codecov Report
@@ Coverage Diff @@
## master #940 +/- ##
========================================
+ Coverage 56.7% 57.2% +0.4%
========================================
Files 150 150
Lines 11190 11192 +2
========================================
+ Hits 6355 6402 +47
+ Misses 4835 4790 -45
Continue to review full report at Codecov.
|
Emantor
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#912 introduced the new kwarg
max_sizeinConsoleExpectMixinwhich is passed through to the driver's internal_read()method. TheQEMUDriverwas not adjusted accordingly, so do that now.While at it, add tests for the
QEMUDriverto prevent such issues in the future.Checklist
Fixes #912