serial/rfc2217: distinguish closed connection and socket error #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jluebbe
reviewed
Dec 17, 2018
Raise a SerialException on socket errors. Use an empty string on peer close just like the recv system call does. In that case return the last data read. Signed-off-by: Bastian Krause <bst@pengutronix.de>
Bastian-Krause
force-pushed
the
bst/rfc2217-connection-error
branch
from
32b4747 to
abc5289
Compare
Bastian-Krause
changed the title
Member
Author
|
Force-pushed a more complete solution "distinguish closed connection and socket error". |
Member
Author
|
I've lost the context of this PR and the issue I tried to fix seems not critical. Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise a SerialException on socket errors. Use an empty string on peer
close just like the recv system call does. In that case return the last
data read.