Skip to content

Conversation

@c121914yu
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings December 18, 2025 15:47
@gru-agent
Copy link
Contributor

gru-agent bot commented Dec 18, 2025

⏳ Processing in progress

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Preview sandbox Image:

registry.cn-hangzhou.aliyuncs.com/fastgpt/fastgpt-pr:fatsgpt_sandbox_26e8830b0460b01a753cfbdebccb8bbd770d677b

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Preview mcp_server Image:

registry.cn-hangzhou.aliyuncs.com/fastgpt/fastgpt-pr:fatsgpt_mcp_server_26e8830b0460b01a753cfbdebccb8bbd770d677b

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors OpenAPI-related type definitions and documentation to improve consistency and clarity. The changes primarily reorganize schema locations, improve Zod schema composition patterns, and enhance API endpoint documentation.

Key changes:

  • Moved presign chat file schemas from packages/global/core/chat/api.ts to packages/global/openapi/core/chat/api.ts for better organization
  • Refactored Zod schema composition from .and() to more idiomatic .extend() pattern
  • Corrected OpenAPI endpoint definitions for presign URLs (schemas and descriptions were swapped)
  • Enhanced API documentation with role-based prefixes (e.g., "应用管理员-") to distinguish admin operations

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
projects/app/src/pages/api/core/chat/presignChatFilePostUrl.ts Updated import path to reflect new schema location
projects/app/src/pages/api/core/chat/presignChatFileGetUrl.ts Updated import path to reflect new schema location
packages/global/support/permission/chat.ts Refactored OutLinkChatAuthSchema to use .extend() instead of .and() for better schema composition
packages/global/openapi/core/chat/index.ts Fixed swapped endpoint definitions and corrected their schemas, summaries, and response types
packages/global/openapi/core/chat/history/api.ts Refactored schema composition from nested .and() to cleaner .extend() pattern
packages/global/openapi/core/chat/feedback/index.ts Reorganized endpoints in logical order and added role-based prefixes to admin operations
packages/global/openapi/core/chat/api.ts New file containing presign URL schemas with improved field descriptions
packages/global/openapi/api.ts Added descriptions to pagination schema fields
packages/global/core/chat/api.ts Deleted file - schemas moved to openapi directory

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Dec 18, 2025

Preview fastgpt Image:

registry.cn-hangzhou.aliyuncs.com/fastgpt/fastgpt-pr:fatsgpt_26e8830b0460b01a753cfbdebccb8bbd770d677b

@github-actions
Copy link

Docs Preview:


🚀 FastGPT Document Preview Ready!

🔗 👀 Click here to visit preview

@c121914yu c121914yu merged commit d398c9c into labring:main Dec 18, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant