feat: keypair garbage collection#2467
Merged
fanux merged 1 commit intolabring:mainfrom Feb 1, 2023
Merged
Conversation
Codecov ReportBase: 65.09% // Head: 65.09% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2467 +/- ##
=======================================
Coverage 65.09% 65.09%
=======================================
Files 8 8
Lines 573 573
=======================================
Hits 373 373
Misses 168 168
Partials 32 32 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
xiaohan1202
force-pushed
the
keypair-gc
branch
2 times, most recently
from
d898af6 to
e3096af
Compare
fanux
reviewed
Jan 31, 2023
| DefaultRegion = "cn-north-1b" | ||
| KeyPairUser = "user" | ||
| KeyPairGeneral = "general" | ||
| KeyPairRoot = "root" |
fanux
reviewed
Jan 31, 2023
| infra.Status.Status = infrav1.Pending.String() | ||
| r.recorder.Eventf(infra, corev1.EventTypeNormal, "InfraPending", "Infra %s status is pending", infra.Name) | ||
| if err := r.Status().Update(ctx, infra); err != nil { | ||
| r.recorder.Eventf(infra, corev1.EventTypeWarning, "infra status to pending failed", "%v", err) |
Member
There was a problem hiding this comment.
"failed to update infra pending status"
fanux
approved these changes
Jan 31, 2023
xiaohan1202
force-pushed
the
keypair-gc
branch
from
e3096af to
4e08042
Compare
fanux
approved these changes
Feb 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add keypair tag to support keypair gc