Open
Conversation
vladhilko
reviewed
Apr 17, 2022
Collaborator
vladhilko
left a comment
vladhilko
left a comment
There was a problem hiding this comment.
Could you apply comments to all specs?
| end | ||
|
|
||
| context 'when log is hash' do | ||
| it 'returns an emrpty array' do |
Collaborator
There was a problem hiding this comment.
Suggested change
| it 'returns an emrpty array' do | |
| it 'returns an empty array' do |
| let(:obj) { described_class.new } | ||
|
|
||
| describe 'task 2' do | ||
| context 'when text wrong' do |
Collaborator
There was a problem hiding this comment.
Suggested change
| context 'when text wrong' do | |
| context 'when text is wrong' do |
| # frozen_string_literal: true | ||
|
|
||
| RSpec.describe Homework3 do | ||
| let(:obj) { described_class.new } |
Collaborator
There was a problem hiding this comment.
Better to use subject
Suggested change
| let(:obj) { described_class.new } | |
| subject { described_class.new } |
| File.delete('spec/helpers/test.txt') | ||
| end | ||
|
|
||
| it 'file created' do |
Collaborator
There was a problem hiding this comment.
use present simple
Suggested change
| it 'file created' do | |
| it 'creates file' do |
| let(:file_name) { 'test.txt' } | ||
|
|
||
| describe '.create_file' do | ||
| context 'when succes create file' do |
Collaborator
There was a problem hiding this comment.
can you rename this context?
Collaborator
|
Try to read https://www.betterspecs.org/ and impove your specs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.