Correctly parse ipv6 host:port for remote workers #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IPv6 addresses contain colons, so we need to split only on the last colon. Zprocess currently has ipv6 disabled by default, but it will be enabled in the next release.
Contributor
|
Simple fix that should have been merged a while ago. I'll go ahead and merge now. |
dihm
added a commit
that referenced
this pull request
Apr 13, 2023
commit 5186769 Author: David Meyer <dihm@users.noreply.github.com> Date: Wed Apr 12 19:43:11 2023 -0400 Update python version support commit e508fcd Merge: 5e3603d 514e7d2 Author: David Meyer <dihm@users.noreply.github.com> Date: Wed Apr 12 19:38:50 2023 -0400 Merge pull request #98 from labscript-suite/qt-float-fix Only pass ints to self.ui.move commit 5e3603d Merge: fb8bcd9 79119b9 Author: David Meyer <dihm@users.noreply.github.com> Date: Wed Apr 12 16:56:39 2023 -0400 Merge pull request #99 from dihm/update-workflow Sync workflow with current state of the art commit 79119b9 Author: David Meyer <dihm@users.noreply.github.com> Date: Wed Apr 12 16:44:29 2023 -0400 Sync workflow with current state of the art commit 514e7d2 Author: chrisjbillington <chrisjbillington@gmail.com> Date: Sat Apr 8 21:11:43 2023 +1000 Only pass ints to self.ui.move as floats to QWidget.move are depreceated and raise an exception. Also update the log line to print the full exception for easier detection of issues in the future. commit fb8bcd9 Merge: 6f7a653 2e6d140 Author: David Meyer <dihm@users.noreply.github.com> Date: Tue Jan 3 12:07:48 2023 -0500 Merge pull request #91 from labscript-suite/ipv6-remotes Correctly parse ipv6 host:port for remote workers commit 6f7a653 Merge: 75ef861 cb87bc7 Author: David Meyer <dihm@users.noreply.github.com> Date: Fri Aug 5 16:45:25 2022 -0400 Merge pull request #96 from dihm/update-workflow Bring workflow up to date with sandbox commit cb87bc7 Author: David Meyer <dihm@users.noreply.github.com> Date: Wed Aug 3 13:24:26 2022 -0400 Bring workflow up to date with sandbox commit 75ef861 Merge: 8551005 029c3b6 Author: David Meyer <dihm@users.noreply.github.com> Date: Thu Jun 2 10:52:25 2022 -0400 Merge pull request #95 from dihm/fix_docs_build Bump sphinx version and update intersphinx links commit 029c3b6 Author: David Meyer <dihm@users.noreply.github.com> Date: Thu Jun 2 10:38:46 2022 -0400 Bump sphinx version and update intersphinx links commit 8551005 Merge: 84731bb cea8ca1 Author: Chris Billington <chrisjbillington@gmail.com> Date: Sun May 1 22:44:25 2022 +1000 Merge pull request #93 from dihm/datetime Upgrade 'run time' to datetime timestamp. commit cea8ca1 Author: David Meyer <dihm@users.noreply.github.com> Date: Sat Apr 30 02:09:32 2022 -0400 Upgrade 'run time' to datetime timestamp. This gives the saved 'run time' resolution better than 1 second. commit 2e6d140 Author: chrisjbillington <chrisjbillington@gmail.com> Date: Sat Jan 29 12:58:52 2022 +1100 Correctly parse ipv6 host:port for remote workers IPv6 addresses contain colons, so we need to split only on the last colon. Zprocess currently has ipv6 disabled by default, but it will be enabled in the next release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPv6 addresses contain colons, so we need to split only on the last
colon.
Zprocess currently has ipv6 disabled by default, but it will be enabled
in the next release.