Use existing QApplication
#75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of creating a new one unconditionally. The splash screen already creates a `QApplication`, so we had two existing in the interpreter. Having multiple `QApplication`s in the same thread (possibly in the same process?) is not allowed and leads to segfaults on `PyQt5` and Python exceptions on `PySide2`. Fixes labscript-suite#74
rpanderson
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating a new one unconditionally. The splash screen already
creates a
QApplication, so we had two existing in the interpreter.Having multiple
QApplications in the same thread (possibly in the sameprocess?) is not allowed and leads to segfaults on
PyQt5and Pythonexceptions on
PySide2.Fixes #74