Skip to content

Conversation

@alexandrestein
Copy link
Contributor

@alexandrestein alexandrestein commented Mar 5, 2018

Fixes #30 and add support for custom ACME endpoint directory.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 4.632% when pulling 7165258 on alexandreStein:labstack-master into cf0db10 on labstack:master.

@coveralls
Copy link

coveralls commented Mar 5, 2018

Coverage Status

Coverage remained the same at 4.632% when pulling 7af48c4 on alexandreStein:labstack-master into cf0db10 on labstack:master.

@alexandrestein
Copy link
Contributor Author

Any reason why this is not merged?
Did you fixed it on an other commit?

@vishr
Copy link
Member

vishr commented Mar 13, 2018

I will review it today, it worked right?

@vishr vishr closed this in b0e0140 Mar 13, 2018
@alexandrestein
Copy link
Contributor Author

Yes, it was working with the previous release.

The pull request appears as not merged but I see all of it in the main branch.

Any reason why you didn't merged it?
In case I'm doing things wrong, I would appreciate to know what.
Other ways, no hard feelings.

@vishr
Copy link
Member

vishr commented Mar 14, 2018

@alexandrestein Somehow there was a merge conflict and I was not in a position to manually merge it. However, your changes are part of the latest release. I will take care of it from next time :). Thanks for your effort.

@alexandrestein
Copy link
Contributor Author

All good, just wanted to know.

@vishr
Copy link
Member

vishr commented Mar 14, 2018

Cool, btw I like your code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants