Bind should return plain error

[aria3ppp]

Regarding #344 original behavior of Bind error was simply return plain error but after #346 it changed to return HTTPError and decided before user and forced user to inflexibly handle error!

current workaround for me is to assert Internal error but it could be nice if the framework do not decide for the user how to handle errors!

[aldas]

I do not think this will happen. HTTPError is for global error handler to figure out which status code to use. It it would be just that internal error the default global error handler would not know what error code to show and everything would fall into 500.

I suggest creating your own version of error handler e.HTTPErrorHandler and if you need to get that wrapped internal error, use this

var httpErr *echo.HTTPError
if errors.As(err, &httpErr) {
	status = httpErr.Code
	wrapped = httpErr.Internal // <-- 
}

and for bind you do not need to response error in handler and can just do

if err := c.Bind(target); err != nil {
   return err // <-- you can return that plain error because HTTPErrorHandler knows how to get correct status from it
}

[aria3ppp]

I do not think this will happen. HTTPError is for global error handler to figure out which status code to use. It it would be just that internal error the default global error handler would not know what error code to show and everything would fall into 500.

I suggest creating your own version of error handler e.HTTPErrorHandler and if you need to get that wrapped internal error, use this

var httpErr *echo.HTTPError
if errors.As(err, &httpErr) {
	status = httpErr.Code
	wrapped = httpErr.Internal // <-- 
}

and for bind you do not need to response error in handler and can just do

if err := c.Bind(target); err != nil {
   return err // <-- you can return that plain error because HTTPErrorHandler knows how to get correct status from it
}

Actually i have my own response structure so i can't just pass along HTTPError.
I just thought once it was just a plain error (and that was ok).
And it could be a v5 breaking change btw!

[aria3ppp]

As i'm learning more about http and rest api it seems a good design choice that echo took to provide its own boiler plate to sanitize requests.
Sometimes i can't help thinking about whose fault (server/client) cause an error so better design is to let framework decide for me ://