Skip to content

[doc] adding graceful documentation and example.#688

Merged
vishr merged 2 commits into
labstack:v3from
paganotoni:v3
Oct 25, 2016
Merged

[doc] adding graceful documentation and example.#688
vishr merged 2 commits into
labstack:v3from
paganotoni:v3

Conversation

@paganotoni

Copy link
Copy Markdown
Contributor

@vishr this adds documentation and sample code for the graceful recipe.

@coveralls

coveralls commented Oct 25, 2016

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 84.856% when pulling 81f09b3 on apaganobeleno:v3 into b2479c2 on labstack:v3.

@paganotoni paganotoni mentioned this pull request Oct 25, 2016
16 tasks
{{< embed "graceful-shutdown/graceful/server.go" >}}
{{< embed "graceful-shutdown/server.go" >}}

### Maintainers

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add yourself in the list.

Comment thread recipe/graceful-shutdown/server.go Outdated
func main() {
e := echo.New()

//Setting up the termination timeout to 30 seconds.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor but to be consistent lets put a space after //.

@vishr vishr merged commit ffdb76e into labstack:v3 Oct 25, 2016
@coveralls

coveralls commented Oct 25, 2016

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 84.856% when pulling a1d8ef7 on apaganobeleno:v3 into b2479c2 on labstack:v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants