Closed
Conversation
Contributor
Author
|
@vishr poke |
Member
|
@AlekSi: Will get back to this, really busy with echo v2 and other stuff. |
Contributor
Author
|
@vishr poke |
Member
|
@AlekSi Thanks for the long wait. You need to re-do your PR as it has conflicts. |
Contributor
Author
|
This PR merely demonstrates the problem, not fixes it. I'm not sure why you are not using Color instances. |
Member
|
I am open for PR ;) |
Contributor
Author
|
If you don't have a specific reason to not use separate instances, then I can fix it. |
Member
|
We should be good with color field for logger - I can't remember why I didn't have this. |
Contributor
Author
|
Closed in favor of #6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically, New() is not thread-safe due to use of exported color functions instead of using own Color instance. Pull request adds test to show that.