Fix a race condition in test_actions_list #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_actions_list sometimes failed, because the invocation expired and was deleted before we called `/action_invocations/` to list the invocations. I believe the problem was that I used an action with a very short retention time (so I could test expiration of the invocation), and it may have expired before I listed the actions. I've now added an action with a longer retention time. If a full second is elapsing between the two requests, something else has gone quite wrong.
Barecheck - Code coverage reportTotal: 92.87%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
julianstirling
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_actions_list sometimes failed, because the invocation expired and was deleted before we called
/action_invocations/to list the invocations.I believe the problem was that I used an action with a very short retention time (so I could test expiration of the invocation), and it may have expired before I listed the actions. I've now added an action with a longer retention time. If a full second is elapsing between the two requests, something else has gone quite wrong.
Closes #170