Add a mock_all_slots option to create_thing_without_server

[julianstirling]

Adds a mock_all_slots option to create_thing_without_server. This will follow the default specified by thing_slot, so if the default is None no mock is created.

If it is a mapping with no default I think one instance is created, this needs checking in a test is tested.

• This needs unit tests before merging.

I have targeted it at #195 so the diff is clear. now targets main

Closes #198

[rwb27]

Great :) Glad this works, and it seems like it wasn't too much code to implement it.

I am thinking that it is probably a sensible idea to create a submodule called testing and move this there - along with probably a few other helpful things (like the not-yet-implemented MockServer). Hopefully that makes it easier to find and import.

[barecheck]

Barecheck - Code coverage report

Total: 94.66%

Your code coverage diff: 0.12% ▴

Uncovered files and lines

File	Lines
src/labthings_fastapi/testing.py	202

[julianstirling]

I understand thing_slots a lot better after implementing this so that is a nice side effect. It is tested.

I think moving it to a testing module is probably a good idea. I like the idea of:

from labthings-fastapi.testing import create_thing_without_server

I think it makes it very clear that this not intended for actual use.

[rwb27]

This looks great. I've made a couple of suggestions that might be nice, but don't change the way it works meaningfully.

It would be good to move this to a testing module as we discussed, I'm happy for you to do that now, or we can do it later.

[rwb27]

Thinking about review order, I think it might make sense to merge #194/#195 without too many more changes, then we can add the testing module and this code in a (very near) future PR.

[julianstirling]

Yeah this is only targeted to #195 so it has a sensible diff. I think aiming it at main once those are merged makes sense

[julianstirling]

@rwb27 I just saw you merged #195. This is now rebased again on main since then. And should be ready to go. I had to fix the mock all slots to connect at the end found a bug in how the test class was declared.

[rwb27]

This looks great - thanks for all the rebasing and updates to test code.

I spotted one thing, which is that you defined a constant for a Thing name but then didn't use it. That's trivial enough that I'll make the change and merge it now - no need to bother you with it.