Accept constraint arguments in property. #208
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`lt.property` now passes some keyword arguments on to `pydantic.Field`. This allows basic numeric constraints to be added to properties. Adding regex patterns and length constraints to strings is also allowed. This is limited at present: * Constraints are only checked when values are set over HTTP, not python. * Constraints are only supported on DataProperties * We don't proactively check constraints are OK, they will only be checked when the model is created. This happens lazily at present. Adding constraints to settings should be trivial. Doing so for functional properties/settings will require a decorator with arguments, which is trickier but possible.
rwb27
force-pushed
the
constraints-on-dataproperty
branch
from
62fc5bf to
f9269fb
Compare
This change also makes `constraints` a public attribute, allowing `FunctionalProperty` (or setting) instances to have constraints set. Both settings and properties, data and functional, are tested.
This also moves the "properties" page out of the tutorial: it's too detailed for that. The new structure is much closer to my original intent.
Fixed a dead link and added an `__all__` to stop exceptions being duplicated.
The additional "constraints" argument was causing a test to fail: this is now fixed.
This wasn't flagged by Ruff, I should possibly just turn off the flake8 code.
Barecheck - Code coverage reportTotal: 95.01%Your code coverage diff: -0.03% ▾ Uncovered files and lines
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lt.propertynow passes some keyword arguments on topydantic.Field. This allows basic numeric constraints to be added to properties. Adding regex patterns and length constraints to strings is also allowed.This is limited at present:
Adding constraints to settings should be trivial. Doing so for functional properties/settings will require a decorator with arguments, which is trickier but possible.
To do before merging:
To think about for the future:
Closes #186