Skip to content

Conversation

@julianstirling
Copy link
Contributor

Fixing the bug where the server thing_descriptions route returns the wrong url for affordances. The / wass missing between the thing name and the action/property name. (See #221).

This is currently 2 commits. The first is a failing unit test, the second is the fix.

@barecheck
Copy link

barecheck bot commented Dec 14, 2025

Barecheck - Code coverage report

Total: 95.07%

Your code coverage diff: 0.04% ▴

Uncovered files and lines
FileLines
src/labthings_fastapi/server/__init__.py167, 317

Copy link
Collaborator

@rwb27 rwb27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting, fixing, and testing this. I'd love to eliminate code that manually manipulated URLs as per #211, but this is a good fix for the immediate problem.

@rwb27 rwb27 merged commit 2cd3eaf into main Dec 14, 2025
14 checks passed
@rwb27 rwb27 deleted the bugfix--server-thing-descriptions branch December 14, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants