Add a helper function to connect Thing Slots on already-created Things.#344
Merged
Conversation
Barecheck - Code coverage reportTotal: 96.88%Your code coverage diff: 0.01% ▴ Uncovered files and lines
|
Contributor
|
I love this. Probably against protocol for it to go in before 0.2 is released? |
Collaborator
Author
|
It's clearly only touching code in OFM v3 check is only failing because of |
This extends `manually_connect_thing_slot` to cope with multiple targets. Note that the targets must have unique names. There's a check for this, and a test that it works. I've also added a test that verifies `Mock` objects work, but they require a `spec` to be set.
julianstirling
approved these changes
May 18, 2026
Contributor
julianstirling
left a comment
julianstirling
left a comment
There was a problem hiding this comment.
One final suggestion for a docstring update then this looks ready to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to mock descriptors is painful, but
lt.thing_slotis relatively easy to reconnect with a little boilerplate.This PR adds a helper function so test code can easily connect
Things together without a server.