Skip to content

Conversation

@joshuataylor
Copy link
Contributor

This is a first draft, taken from my ramblings on labwc/labwc#828 .

Please leave feedback around style, grammar, spelling and also technical information and other tips and tricks.

I've marked this as a draft until everyone is happy with it, and have allowed edits from maintainers.

Just wanted to also say thank you for the work y'all do on Labwc, it's fantastic. :)

Copy link
Member

@Consolatis Consolatis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all: nice write-up.

Some nitpicks below that stood out to me while reading.

Another thing that came up for me while reading is that the whole XWayland thing is pretty much experimental and requires quite a bit of work and knowledge (which this guide does a good job of providing). But maybe it should be stated more clearly that the XWayland part is not intended for the casual user and more for people who want to get their hands dirty.

@johanmalm
Copy link
Member

Looks good. Thanks for your work on this.
Please don't be deterred by the number of comments 😄
Writing this sort of stuff is not easy and you've made a great effort.

@joshuataylor
Copy link
Contributor Author

Thank you very much for taking the time to provide fantastic notes and feedback!

Very much appreciated, I'll get it updated ASAP.

@kyak
Copy link

kyak commented Dec 2, 2023

@joshuataylor i've just stumbled upon this draft. It's great that you've taken the challenge to document this and put it together.

Do you plan to finish it up eventually?

@johanmalm
Copy link
Member

I started tidying this up. Can push if @joshuataylor wants me to / does not respond.

@joshuataylor
Copy link
Contributor Author

joshuataylor commented Dec 2, 2023

My apologies, the second half of year has been crazy personal wise and I haven't had a chance to return to this yet.

Feel free to adopt this PR, and change anything to your liking - the more knowledge around this topic, the better (thanks so much by the way!).

edit: Also, this topic moves QUICK, as it's in active development, so feel free to remove anything specific, also happy to clarify anything, please ping me and I'll do my best to respond (it's calmed now :-)). 👍

@johanmalm
Copy link
Member

@joshuataylor I've tweaked/refactored a bit + rebased on main.
I've put the patch-sections on a separate page because they're quite deep. I assume the patching can be simplified a bit now that we're on wlroots 0.17. It's not obvious to me how to simplify this. Could you give me some pointers?

@johanmalm johanmalm marked this pull request as ready for review January 2, 2024 21:12
@johanmalm johanmalm merged commit 2471368 into labwc:main Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants