fix(COD-6066): hide the Lacework credentials from the running commands#251
Merged
jeremydubreil merged 1 commit intomainfrom Mar 25, 2026
Merged
fix(COD-6066): hide the Lacework credentials from the running commands#251jeremydubreil merged 1 commit intomainfrom
jeremydubreil merged 1 commit intomainfrom
Conversation
jeremydubreil
force-pushed
the
hide-environment-variables
branch
2 times, most recently
from
e3eb86b to
8ed7b41
Compare
jeremydubreil
force-pushed
the
hide-environment-variables
branch
10 times, most recently
from
22e22e6 to
cc57013
Compare
jeremydubreil
force-pushed
the
hide-environment-variables
branch
from
cc57013 to
f5b6c80
Compare
| if: ${{ inputs.debug == 'true' }} | ||
| run: | | ||
| echo "LW_LOG=debug" >> $GITHUB_ENV | ||
| - name: Set Lacework account environment variable |
Contributor
There was a problem hiding this comment.
This is for backward compatibility?
Contributor
Author
There was a problem hiding this comment.
Yes, and it seems to work now. I am testing this on WebGoat.
| ] | ||
| info('Calling lacework ' + expandedArgs.join(' ')) | ||
| await callCommand('lacework', ...expandedArgs) | ||
| await callCommand('lacework', '--noninteractive', 'sca', ...args) |
Contributor
There was a problem hiding this comment.
how come the credentials no longer need passing?
Contributor
Author
There was a problem hiding this comment.
Because they are passed as environment. Before the changes, the workflow was setting the environment environment variables but not using them as such as it was overriding them with the -a, -k, and -s of the lacework CLI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested here on WebGoat for the scheduled runs and here for the PR comments.